ISSUE #1060 - step 1 - change org.mongodb.morphia to#1122
ISSUE #1060 - step 1 - change org.mongodb.morphia to#1122velo merged 7 commits intoOpenFeign:masterfrom
Conversation
dev.morphia.morphia
kamilkrzywanski
force-pushed
the
issue_1060
branch
from
422631d to
a40a3b6
Compare
|
Circle CI doesn't inject env-vars for PRs initiated by 3rd parties |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #1122 +/- ##
============================================
+ Coverage 61.18% 71.03% +9.85%
Complexity 84 84
============================================
Files 830 857 +27
Lines 32014 32348 +334
Branches 3591 3600 +9
============================================
+ Hits 19588 22979 +3391
+ Misses 11179 8144 -3035
+ Partials 1247 1225 -22 ☔ View full report in Codecov by Sentry. |
velo
left a comment
velo
left a comment
There was a problem hiding this comment.
Great work, this change is long overdue.
I'm willing to break the API signature for next minor release, as this is a 3rd party change and I don't think this has been heavily used.
Just bring the plugin back.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the codebase to use the new dev.morphia library rather than the deprecated org.mongodb.morphia package. The key changes include replacing all Morphia-related import statements, adjusting test files to accommodate the new package, and updating the query API to use countDocuments in place of count.
Reviewed Changes
Copilot reviewed 28 out of 31 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Food.java, Fish.java, DummyEntity.java, Dates.java, Country.java, Chips.java, Address.java, AbstractEntity.java | Updated import statements from org.mongodb.morphia to dev.morphia |
| MongodbQueryTest.java, MongodbSerializerTest.java, MongodbPolymorphicCollectionTest.java, MongodbJoinTest.java, MongodbGeoSpatialQueryTest.java | Updated import statements in test files to reference dev.morphia |
| MorphiaSerializer.java, MorphiaQuery.java | Updated import statements to use dev.morphia API |
| AbstractFetchableMongodbQuery.java | Changed query count from count() to countDocuments() to align with the new API |
Files not reviewed (3)
- pom.xml: Language not supported
- querydsl-libraries/pom.xml: Language not supported
- querydsl-libraries/querydsl-mongodb/pom.xml: Language not supported
Comments suppressed due to low confidence (1)
querydsl-libraries/querydsl-mongodb/src/test/java/com/querydsl/mongodb/document/AbstractFetchableMongodbQuery.java:230
- Verify that the use of countDocuments() accurately replicates the behavior of count() and returns the expected data type, as the new API might have subtle differences.
return collection.countDocuments(createQuery(filter));
dev.morphia.morphia - skipping japicmp
kamilkrzywanski
force-pushed
the
issue_1060
branch
from
7ab2152 to
785c0fd
Compare
|
<japicmp.skip>true</japicmp.skip> added to mongo module |
dev.morphia.morphia - fix tests
…2 -> make tests work again
….11.5 - revert ensure indexes
|
@velo seems to be done. There are a few things that could be updated (like removing deprecated code in the tests), but it's not necessary to address them right now. I’ll try to take care of it in the future when I find some free time. |
ISSUE #1060 - step 1 - change org.mongodb.morphia to dev.morphia.morphia - will be update to lastest version, now I only want to build it with CICD